Updated AGP and KGP to align with flutter/flutter templates #10423
Conversation
jesswrd
requested review from
Hixie,
Piinks,
bparrishMines,
camsim99,
chunhtai,
domesticmouse,
gmackall,
hannah-hyj,
mboetger,
reidbaker,
stuartmorgan-g and
tarrinneal
as code owners
github-actions
bot
added
p: extension_google_sign_in_as_googleapis_auth
p: pigeon
p: rfw
github-actions
bot
added
p: webview_flutter
p: video_player
p: url_launcher
p: shared_preferences
p: two_dimensional_scrollables
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Android Gradle Plugin (AGP) and Kotlin Gradle Plugin (KGP) versions across numerous settings.gradle files. The changes correctly align the versions with the flutter/flutter templates. However, I've identified several files where the indentation of the updated lines is inconsistent with the surrounding code within the plugins block. I have added comments with suggestions to correct the formatting for better code maintainability.
packages/extension_google_sign_in_as_googleapis_auth/example/android/settings.gradle
Show resolved
Hide resolved
| id "com.android.application" version "8.11.1" apply false | ||
| id "org.jetbrains.kotlin.android" version "2.2.20" apply false |
There was a problem hiding this comment.
The indentation for these lines is inconsistent with the rest of the plugins block. Please use 2 spaces for indentation to match the surrounding lines.
id "com.android.application" version "8.11.1" apply false
id "org.jetbrains.kotlin.android" version "2.2.20" apply false
| id "com.android.application" version "8.11.1" apply false | ||
| id "org.jetbrains.kotlin.android" version "2.2.20" apply false |
There was a problem hiding this comment.
The indentation for these lines is inconsistent with the rest of the plugins block. Please use 2 spaces for indentation to match the surrounding lines.
id "com.android.application" version "8.11.1" apply false
id "org.jetbrains.kotlin.android" version "2.2.20" apply false
| id "com.android.application" version "8.11.1" apply false | ||
| id "org.jetbrains.kotlin.android" version "2.2.20" apply false |
There was a problem hiding this comment.
The indentation for these lines is inconsistent with the rest of the plugins block. Please use 2 spaces for indentation to match the surrounding lines.
id "com.android.application" version "8.11.1" apply false
id "org.jetbrains.kotlin.android" version "2.2.20" apply false
| id "com.android.application" version "8.11.1" apply false | ||
| id "org.jetbrains.kotlin.android" version "2.2.20" apply false |
There was a problem hiding this comment.
The indentation for these lines is inconsistent with the rest of the plugins block. Please use 2 spaces for indentation to match the surrounding lines.
id "com.android.application" version "8.11.1" apply false
id "org.jetbrains.kotlin.android" version "2.2.20" apply false
| id "com.android.application" version "8.11.1" apply false | ||
| id "org.jetbrains.kotlin.android" version "2.2.20" apply false |
There was a problem hiding this comment.
The indentation for these lines is inconsistent with the rest of the plugins block. Please use 2 spaces for indentation to match the surrounding lines.
id "com.android.application" version "8.11.1" apply false
id "org.jetbrains.kotlin.android" version "2.2.20" apply false
| id "com.android.application" version "8.11.1" apply false | ||
| id "org.jetbrains.kotlin.android" version "2.2.20" apply false |
There was a problem hiding this comment.
The indentation for these lines is inconsistent with the rest of the plugins block. Please use 2 spaces for indentation to match the surrounding lines.
id "com.android.application" version "8.11.1" apply false
id "org.jetbrains.kotlin.android" version "2.2.20" apply false
| id "com.android.application" version "8.11.1" apply false | ||
| id "org.jetbrains.kotlin.android" version "2.2.20" apply false |
There was a problem hiding this comment.
The indentation for these lines is inconsistent with the rest of the plugins block. Please use 2 spaces for indentation to match the surrounding lines.
id "com.android.application" version "8.11.1" apply false
id "org.jetbrains.kotlin.android" version "2.2.20" apply false
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
looks like some spacing got messed up but lgtm outside that
jesswrd
force-pushed
the
update-agp-kgp
branch
from
8cbc0ca to
6bc6894
Compare
| mavenCentral() | ||
| gradlePluginPortal() | ||
| } | ||
| } |
There was a problem hiding this comment.
It's interesting that the indent (2 vs 4 spaces) of this block isn't consistent across files. I don't think it's worth worrying about though, since once we migrate everything to Kotlin it'll be autoformatted anyway.
4 participants
Updated the example app agp and kgp versions to match the template defaults.
AGP 8.11.0 --> 8.11.1
KGP 2.2.0 --> 2.2.20
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3